Skip to content

feat(locale): add Japanese fish definitions#3721

Merged
xDivisionByZerox merged 3 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-fish
Mar 11, 2026
Merged

feat(locale): add Japanese fish definitions#3721
xDivisionByZerox merged 3 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-fish

Conversation

@atzzCokeK
Copy link
Contributor

@atzzCokeK atzzCokeK commented Jan 31, 2026

Summary

Add fish definitions for the Japanese (ja) locale.

Added files

fish.ts - Fish species (40 items)

Japanese freshwater fish

金魚, 錦鯉, メダカ, ドジョウ, フナ, 鯉, アユ, ヤマメ, イワナ, etc.

Aquarium fish

グッピー, ネオンテトラ, エンゼルフィッシュ, ベタ, アロワナ, etc.

References

Test plan

  • pnpm run generate:locales executed successfully

@netlify
Copy link

netlify bot commented Jan 31, 2026 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ebc0c3a
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69b173e48df125000883ea21
😎 Deploy Preview https://deploy-preview-3721.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (dc31ff8) to head (ebc0c3a).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #3721      +/-   ##
==========================================
- Coverage   98.88%   98.82%   -0.07%     
==========================================
  Files         886      886              
  Lines        3062     3062              
  Branches      556      556              
==========================================
- Hits         3028     3026       -2     
- Misses         30       32       +2     
  Partials        4        4
Files with missing lines Coverage Δ
src/locales/ja/animal/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Feb 6, 2026

Hi @atzzCokeK 👋
I see that all you currently opened PRs are in draft. I assumed you did this to make us focus on one PR at the time, so we do not "bounce" between PRs and run into problems with the snapshot in an uncoordinated manner.
If that is the case, do we want to continue with this PR? Just mark your PR "Ready for review" if you approve with this process. The snapshot tests need an update and the locale file generation needs to be run again, as well.
We appreciate your support 🙏

@atzzCokeK
Copy link
Contributor Author

atzzCokeK commented Feb 7, 2026

@xDivisionByZerox Yes, what you mentioned is perfectly right. I’ll do a final check on this PR and mark it as Ready for review soon. Thanks you🙏🏽

@atzzCokeK atzzCokeK force-pushed the feat/ja-animal-fish branch from 1255ad2 to 52b9854 Compare February 7, 2026 04:14
@atzzCokeK atzzCokeK marked this pull request as ready for review February 7, 2026 04:15
@atzzCokeK atzzCokeK requested a review from a team as a code owner February 7, 2026 04:15
matthewmayer
matthewmayer previously approved these changes Feb 7, 2026
View reviewed changes
Shinigami92
Shinigami92 previously approved these changes Feb 11, 2026
View reviewed changes
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Feb 25, 2026
ST-DDT
ST-DDT previously approved these changes Feb 25, 2026
View reviewed changes
@atzzCokeK
feat(locale): add Japanese fish definitions
005b828 
T_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq add src/locales/ja/animal/index.ts && GIT_EDITOR=true git -C /Users/atsushi.kawamura/.cursor/worktrees/faker/vmq rebase --continue
@atzzCokeK
test: update snapshot
fa07a6f
@atzzCokeK atzzCokeK dismissed stale reviews from ST-DDT, Shinigami92, and matthewmayer via fa07a6f February 26, 2026 05:32
ST-DDT
ST-DDT previously approved these changes Feb 26, 2026
View reviewed changes
@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Mar 11, 2026
@ST-DDT ST-DDT requested review from a team March 11, 2026 14:18
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 11, 2026
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Mar 11, 2026
Merged via the queue into faker-js:next with commit 15fc361 Mar 11, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@matthewmayer matthewmayer matthewmayer left review comments

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees

@atzzCokeK atzzCokeK

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atzzCokeK @xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92